[all-commits] [llvm/llvm-project] cdb42a: Disable unique linkage suffixes ifor global vars u...

[Sriraman Tallam via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cdb42a4cc4239c0b592fc82021c945ce02ebe5cc
      https://github.com/llvm/llvm-project/commit/cdb42a4cc4239c0b592fc82021c945ce02ebe5cc
  Author: Sriraman Tallam <tmsriram at google.com>
  Date:   2021-03-11 (Thu, 11 Mar 2021)

  Changed paths:
    M clang/lib/AST/ItaniumMangle.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGen/unique-internal-linkage-names-dwarf.c
    M clang/test/CodeGen/unique-internal-linkage-names-dwarf.cpp
    M clang/test/CodeGen/unique-internal-linkage-names.cpp

  Log Message:
  -----------
  Disable unique linkage suffixes ifor global vars until demanglers can be fixed.

D96109 added support for unique internal linkage names for both internal
linkage functions and global variables. There was a lot of discussion on how to
get the demangling right for functions but I completely missed the point that
demanglers do not support suffixes for global vars. For example:

$ c++filt _ZL3foo
foo
$ c++filt _ZL3foo.uniq.123
_ZL3foo.uniq.123

The demangling for functions works as expected.

I am not sure of the impact of this. I don't understand how debuggers and other
tools depend on the correctness of global variable demangling so I am
pre-emptively disabling it until we can get the demangling support added.

Importantly, uniquefying global variables is not needed right now as we do not
do profile attribution to global vars based on sampling. It was added for
completeness and so this feature is not exactly missed.

Differential Revision: https://reviews.llvm.org/D98392