[all-commits] [llvm/llvm-project] cb2648: [libcxx] [test] Use a string_view of the native pa...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb2648e6f0fbed25ffbb6cb5d9b76d46f39001aa
      https://github.com/llvm/llvm-project/commit/cb2648e6f0fbed25ffbb6cb5d9b76d46f39001aa
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-11 (Thu, 11 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Use a string_view of the native path type in the concat test

This makes sure that no extra allocations happen on windows, fixing
earlier errors in the DisableAllocationGuard (in the second case that
is modified).

This is split out from D98398.

Differential Revision: https://reviews.llvm.org/D98406


  Commit: 49173ca4db21e4d1576c2440b79ebff48c6c4156
      https://github.com/llvm/llvm-project/commit/49173ca4db21e4d1576c2440b79ebff48c6c4156
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-11 (Thu, 11 Mar 2021)

  Changed paths:
    M libcxx/include/filesystem
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp

  Log Message:
  -----------
  [libcxx] Avoid intermediate string objects for substrings in windows operator/=

Check that appends with a path object doesn't do allocations, even
on windows.

Suggested by Marek in D98398. The patch might apply without D98398
(depending on how much of the diff context has to match), but doesn't
make much sense until after that patch has landed.

Differential Revision: https://reviews.llvm.org/D98412


Compare: https://github.com/llvm/llvm-project/compare/e4f385d89448...49173ca4db21