[all-commits] [llvm/llvm-project] c34761: [FileCheck] Fix naming of OverflowErrorStr var

RoboTux via All-commits all-commits at lists.llvm.org
Thu Mar 11 02:31:11 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c347619bc2baef2d0e494e8350bd21546a6c126f
      https://github.com/llvm/llvm-project/commit/c347619bc2baef2d0e494e8350bd21546a6c126f
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2021-03-11 (Thu, 11 Mar 2021)

  Changed paths:
    M llvm/lib/FileCheck/FileCheck.cpp

  Log Message:
  -----------
  [FileCheck] Fix naming of OverflowErrorStr var

As pointed out by Joel E. Denny in D97845, the OverflowErrorStr variable
is misnamed because the error is raised for any parsing error. Note that
in FileCheck proper this only happens in case of (under|over)flow
because the regex will ensure a number in the correct format is matched.

Reviewed By: jdenny

Differential Revision: https://reviews.llvm.org/D98342




More information about the All-commits mailing list