[all-commits] [llvm/llvm-project] fdc0c2: [lld-macho][NFC] when reasonable, replace auto key...

[Greg McGary via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fdc0c21973c80b56381888c84125bdec7c1c1fbe
      https://github.com/llvm/llvm-project/commit/fdc0c21973c80b56381888c84125bdec7c1c1fbe
  Author: Greg McGary <gkm at fb.com>
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/DriverUtils.cpp
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputSection.cpp
    M lld/MachO/LTO.cpp
    M lld/MachO/SymbolTable.cpp
    M lld/MachO/SyntheticSections.cpp
    M lld/MachO/UnwindInfoSection.cpp

  Log Message:
  -----------
  [lld-macho][NFC] when reasonable, replace auto keyword with type names

lld policy discourages `auto`. Replace it with a type name whenever reasonable. Retain `auto` to avoid ...
* redundancy, as for decls such as `auto *t = mumble_cast<TYPE *>` or similar that specifies the result type on the RHS
* verbosity, as for iterators
* gratuitous suffering, as for lambdas

Along the way, add `const` when appropriate.

Note: a future diff will ...
* add more `const` qualifiers
* remove `opt::` when we are already `using llvm::opt`

Differential Revision: https://reviews.llvm.org/D98313


  Commit: 714ec86c024370cbe8d6d4472e2226682e1c42e2
      https://github.com/llvm/llvm-project/commit/714ec86c024370cbe8d6d4472e2226682e1c42e2
  Author: Greg McGary <gkm at fb.com>
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/DriverUtils.cpp

  Log Message:
  -----------
  [lld-macho][NFC] drop opt:: when already using llvm::opt

Top-level `using llvm::opt` has been present in `lld/MachO/Driver*.cpp` for some time, so remove lingering `opt::` prefixes.

Differential Revision: https://reviews.llvm.org/D98314


Compare: https://github.com/llvm/llvm-project/compare/ee35784a909b...714ec86c0243