[all-commits] [llvm/llvm-project] b04fbc: [flang][driver] Refine tests for module search dir...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Tue Mar 9 07:27:21 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b04fbc191325a0fc07eb6882f5ab85123b6dc165
      https://github.com/llvm/llvm-project/commit/b04fbc191325a0fc07eb6882f5ab85123b6dc165
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2021-03-09 (Tue, 09 Mar 2021)

  Changed paths:
    M flang/test/Flang-Driver/Inputs/module-dir/basictestmoduleone.mod
    M flang/test/Flang-Driver/Inputs/module-dir/basictestmoduletwo.mod
    R flang/test/Flang-Driver/include-module.f90
    A flang/test/Flang-Driver/use-module-error.f90
    A flang/test/Flang-Driver/use-module.f90

  Log Message:
  -----------
  [flang][driver] Refine tests for module search directories

This patch refactors include-module.f90:
  * rename the test file as use-module.f90 to better highlight which
  driver feature is being tested
  * move tests for diagnostics to use-module-error.f90 (it tests that
  `-J/-module-dir` can only be used once)
  * make sure that `f18` is tested when `FLANG_BUILD_NEW_DRIVER` is
  set to `Off`
  * add tests for when all module files are successfully discovered and
  loaded

With this patch, there should be a clear separation into 3 scenarios in
use-module.f90:
  * Everything is OK
  * One module file wasn't found (missing include path for
  basictestingmoduletwo.mod)
  * Two module files are found, but the test requires
  `basictestingmoduleone.mod` from both `Inputs` and `Inputs/module-dir`.
  Only the latter is found.

Reviewed By: tskeith

Differential Revision: https://reviews.llvm.org/D97197




More information about the All-commits mailing list