[all-commits] [llvm/llvm-project] f71cee: [X86] Break if-else chain. NFCI.

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Mon Mar 8 03:44:57 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f71cee136d7ea83b21c099e04d5807e2f5cff88e
      https://github.com/llvm/llvm-project/commit/f71cee136d7ea83b21c099e04d5807e2f5cff88e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-03-08 (Mon, 08 Mar 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Break if-else chain. NFCI.

Both if blocks affect control flow - we don't need the else.

Fixes clang-tidy warning.


  Commit: c2d18d700500991eff15ac674dacdeb3e1d8c21d
      https://github.com/llvm/llvm-project/commit/c2d18d700500991eff15ac674dacdeb3e1d8c21d
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-03-08 (Mon, 08 Mar 2021)

  Changed paths:
    M llvm/lib/Support/KnownBits.cpp
    M llvm/test/Transforms/InstSimplify/icmp-constant.ll

  Log Message:
  -----------
  [KnownBits] Add min/max shift amount handling to shl/lshr/ashr KnownBits helpers

Pulled out of the original D90479 patch - also includes the "impossible shift amount" filtering from computeKnownBitsFromShiftOperator.

Differential Revision: https://reviews.llvm.org/D90479


Compare: https://github.com/llvm/llvm-project/compare/ad294e572bc5...c2d18d700500


More information about the All-commits mailing list