[all-commits] [llvm/llvm-project] 4d571c: [libcxx] [test] Clarify and improve consistency in...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4d571cf4e99e3a7abe898dbbc02b2e872e9490e8
      https://github.com/llvm/llvm-project/commit/4d571cf4e99e3a7abe898dbbc02b2e872e9490e8
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-07 (Sun, 07 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.gen/lexically_relative_and_proximate.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Clarify and improve consistency in lexically_relative_and_proximate.pass.cpp. NFC.

Use "expect" instead of "output" for generating "proximate_expected",
pass the arguments to PathEq in the same order as above, rename the
"proximate_expected" variable to be consistent with the naming of the
earlier "expect", use .empty() instead of .native().empty().

Differential Revision: https://reviews.llvm.org/D98127


  Commit: 52c5f5ad5f203d4659f0613a6133f85688ff8266
      https://github.com/llvm/llvm-project/commit/52c5f5ad5f203d4659f0613a6133f85688ff8266
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-07 (Sun, 07 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix building create_directory in MSVC configurations

Don't use the mode_t type - the official windows sdk doesn't have that type.
(Mingw headers does have such a typedef though.) The umask function returns
int on windows, in both header variants.

Thus just use auto to deduce the umask return type automatically.

Differential Revision: https://reviews.llvm.org/D98140


  Commit: 3a11a41795bec548e91621caaa4cc00fc31b2212
      https://github.com/llvm/llvm-project/commit/3a11a41795bec548e91621caaa4cc00fc31b2212
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-07 (Sun, 07 Mar 2021)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Don't test CharFile (/dev/null) on windows

Also clarify a nearby comment regarding block devices.

Differential Revision: https://reviews.llvm.org/D98138


Compare: https://github.com/llvm/llvm-project/compare/bde2e5607167...3a11a41795be