[all-commits] [llvm/llvm-project] 10a728: [runtimes] Fix crosscompiling after a7cad6680b4087...

Raul Tambre via All-commits all-commits at lists.llvm.org
Sat Mar 6 01:35:27 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10a7289649cfb0352f2222286920d26da22c625f
      https://github.com/llvm/llvm-project/commit/10a7289649cfb0352f2222286920d26da22c625f
  Author: Raul Tambre <raul.tambre at cleveron.com>
  Date:   2021-03-06 (Sat, 06 Mar 2021)

  Changed paths:
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake

  Log Message:
  -----------
  [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451)

It moved the logic for CMake target arguments into llvm_ExternalProject_Add().
No handling was added for CMAKE_CROSSCOMPILING, which has a separate set of compiler_args.
This broke crosscompiling, as now the runtimes builds defaulted to the compiler's default.

I've also added passing of CMAKE_ASM_COMPILER, which was missing before although we were passing the triple for it.

Reviewed By: zero9178

Differential Revision: https://reviews.llvm.org/D97855




More information about the All-commits mailing list