[all-commits] [llvm/llvm-project] 002dd4: [clang] Fix typos in the default logic for CLANG_D...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Mar 5 23:10:06 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 002dd47bdd674fad8186650f07458b1e062545df
      https://github.com/llvm/llvm-project/commit/002dd47bdd674fad8186650f07458b1e062545df
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-06 (Sat, 06 Mar 2021)

  Changed paths:
    M clang/CMakeLists.txt

  Log Message:
  -----------
  [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

CLANG_DEFAULT_RTLIB had a typo, and libunwind isn't a valid
option for it.

This keeps the actual behaviour from before, defaulting to none if
using compiler-rt as rtlib.

Differential Revision: https://reviews.llvm.org/D98022


  Commit: ebe6d3be0f73c15e64b1ebafd2a4b9fa836be78c
      https://github.com/llvm/llvm-project/commit/ebe6d3be0f73c15e64b1ebafd2a4b9fa836be78c
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-06 (Sat, 06 Mar 2021)

  Changed paths:
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/test/Driver/compiler-rt-unwind.c

  Log Message:
  -----------
  [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

For MinGW targets, we distinguish between an explicitly shared unwinder
library (requested via -shared-libgcc), an explicitly static one
(requested via -static-libgcc or -static) and the default case (which
just passes -lunwind to the linker, which will pick either shared or
static depending on what's available, with the normal linker logic).

This makes the implicit default case (as added in D79995) actually work as
it was intended, when using the g++ driver (which is the main usecase for
libunwind as far as I know).

Differential Revision: https://reviews.llvm.org/D98023


  Commit: 714644a36c3095e1dffeb2fb42da3876a5919d21
      https://github.com/llvm/llvm-project/commit/714644a36c3095e1dffeb2fb42da3876a5919d21
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-06 (Sat, 06 Mar 2021)

  Changed paths:
    M libcxx/utils/libcxx/test/target_info.py

  Log Message:
  -----------
  [libcxx] [test] Move the is_<platform> functions down to subclasses

If cross testing (and manually specifying a LIBCXX_TARGET_INFO in the
cmake configuration, as the default is to match the build platform),
we want the accessors for querying the target platform, is_windows,
is_darwin, to return the right value depending on which target info
class is used, not based on what platform is running the build and
driving the tests.

When LIBCXX_TARGET_INFO isn't defined, the right target info class
is chosen automatically based on the platform one is running on, so
this shouldn't make any practical difference for such setups.

Differential Revision: https://reviews.llvm.org/D98045


Compare: https://github.com/llvm/llvm-project/compare/2d922de3af40...714644a36c30


More information about the All-commits mailing list