[all-commits] [llvm/llvm-project] fc011b: [lld-macho] Replace debug-info-related assert with...

Jez Ng via All-commits all-commits at lists.llvm.org
Fri Mar 5 14:24:50 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc011b5eb1a3e3837855149c57ae9c8acc709a0a
      https://github.com/llvm/llvm-project/commit/fc011b5eb1a3e3837855149c57ae9c8acc709a0a
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp

  Log Message:
  -----------
  [lld-macho] Replace debug-info-related assert with FIXME

We'll need to properly handle object files with multiple source inputs
eventually, but remove the assert for now so we can successfully emit binaries
for testing.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D98067


  Commit: 3c19b4f34d6a2a2fb628a3db9225a5167e363234
      https://github.com/llvm/llvm-project/commit/3c19b4f34d6a2a2fb628a3db9225a5167e363234
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/MachO/SyntheticSections.cpp
    M lld/test/MachO/stabs.s

  Log Message:
  -----------
  [lld-macho] Skip over symbols in un-parsed debug info sections

clang appears to emit symbols in `__debug_aranges`, at least
for arm64... in the examples I've seen, it doesn't seem like those
symbols are referenced outside of `__DWARF`, so I think they're safe to
ignore. But hopefully @clayborg can confirm.

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D98073


Compare: https://github.com/llvm/llvm-project/compare/c0d390d0d26b...3c19b4f34d6a


More information about the All-commits mailing list