[all-commits] [llvm/llvm-project] adc35b: [mlir][sparse] mask reduction update

Aart Bik via All-commits all-commits at lists.llvm.org
Fri Mar 5 08:56:36 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: adc35b689f3a31c57fe56a8850c9c17fffea7199
      https://github.com/llvm/llvm-project/commit/adc35b689f3a31c57fe56a8850c9c17fffea7199
  Author: Aart Bik <ajcbik at google.com>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Sparsification.cpp
    M mlir/test/Dialect/Linalg/sparse_vector.mlir

  Log Message:
  -----------
  [mlir][sparse] mask reduction update

Reduction updates should be masked, just like the load and stores.
Note that alternatively, we could use the fact that masked values are
zero of += updates and mask invariants to get this working but that
would not work for *= updates. Masking the update itself is cleanest.
This change also replaces the constant mask with a broadcast of "true"
since this constant folds much better for various folding patterns.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D98000




More information about the All-commits mailing list