[all-commits] [llvm/llvm-project] a60d06: [clangd] Rename Module -> FeatureModule to avoid c...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri Mar 5 01:15:17 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a60d06d8b757b656726b70e83e76417297c7057b
      https://github.com/llvm/llvm-project/commit/a60d06d8b757b656726b70e83e76417297c7057b
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-03-05 (Fri, 05 Mar 2021)

  Changed paths:
    M clang-tools-extra/clangd/CMakeLists.txt
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/ClangdServer.cpp
    M clang-tools-extra/clangd/ClangdServer.h
    A clang-tools-extra/clangd/FeatureModule.cpp
    A clang-tools-extra/clangd/FeatureModule.h
    R clang-tools-extra/clangd/Module.cpp
    R clang-tools-extra/clangd/Module.h
    M clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp

  Log Message:
  -----------
  [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

As pointed out in D96244, "Module" is already pretty overloaded to refer
to clang and llvm modules. (And clangd deals directly with the former).

FeatureModule is a bit of a mouthful but it's pretty self-descriptive.
I think it might be better than "Component" which doesn't really capture
the "common interface" aspect - it's IMO confusing to refer to
"components" but exclude CDB for example.

Differential Revision: https://reviews.llvm.org/D97950




More information about the All-commits mailing list