[all-commits] [llvm/llvm-project] c16fef: [lldb/Interpreter] Make OptionGroupPythonClassWith...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Thu Mar 4 11:25:16 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c16fef19f6b002ba6ec7104d9f7dc44fef99ef57
      https://github.com/llvm/llvm-project/commit/c16fef19f6b002ba6ec7104d9f7dc44fef99ef57
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2021-03-04 (Thu, 04 Mar 2021)

  Changed paths:
    M lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h
    M lldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp

  Log Message:
  -----------
  [lldb/Interpreter] Make OptionGroupPythonClassWithDict options non-required

When using `OptionGroupPythonClassWithDict` options in an `OptionGroup`
with other `Options`, it can happen that the combinaison of some options
of each group makes the command invalid.

To solve that issue, this patch adds a bitmask argument to the
`OptionGroupPythonClassWithDict` constuctor that is used to mark each
option as required (or not).

If the `required_options` bitmask isn't passed to the constructor, the
class will keep its default behaviour, making the `--script-class` and
`--python-function` required.

rdar://65508855

Differential Revision: https://reviews.llvm.org/D97910

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>




More information about the All-commits mailing list