[all-commits] [llvm/llvm-project] 553cb6: [mlir][sparse] fix bug in reduction chain

Aart Bik via All-commits all-commits at lists.llvm.org
Wed Mar 3 17:38:47 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 553cb6d473c55556146e5c9cc9cd31af99ce99cb
      https://github.com/llvm/llvm-project/commit/553cb6d473c55556146e5c9cc9cd31af99ce99cb
  Author: Aart Bik <ajcbik at google.com>
  Date:   2021-03-03 (Wed, 03 Mar 2021)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Sparsification.cpp
    M mlir/test/Dialect/Linalg/sparse_1d.mlir

  Log Message:
  -----------
  [mlir][sparse] fix bug in reduction chain

Found with exhaustive testing, it is possible that a while loop
appears in between chainable for loops. As long as we don't
scalarize reductions in while loops, this means we need to
terminate the chain at the while. This also refactors the
reduction code into more readable helper methods.

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D97886




More information about the All-commits mailing list