[all-commits] [llvm/llvm-project] e984c2: Revert "hack to unbreak check-llvm on win after D9...
Stefan Gränitz via All-commits
all-commits at lists.llvm.org
Wed Mar 3 13:52:23 PST 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: e984c2b06f0c59265ba2172bbdb2811c72123701
https://github.com/llvm/llvm-project/commit/e984c2b06f0c59265ba2172bbdb2811c72123701
Author: Stefan Gränitz <stefan.graenitz at gmail.com>
Date: 2021-03-03 (Wed, 03 Mar 2021)
Changed paths:
M llvm/tools/llvm-jitlink/CMakeLists.txt
M llvm/tools/llvm-jitlink/llvm-jitlink.cpp
M llvm/utils/gn/secondary/llvm/tools/llvm-jitlink/BUILD.gn
Log Message:
-----------
Revert "hack to unbreak check-llvm on win after D97335" in attempt for actual fix
This reverts commit 900f076113302e26e1939541b546b0075e3e9721 and attempts an actual fix: All failing tests for llvm-jitlink use the `-noexec` flag. The inputs they operate on are not meant for execution on the host system. Looking e.g. at the MachO_test_harness_harnesss.s test, llvm-mc generates input machine code with "x86_64-apple-macosx10.9".
My previous attempt in bbdb4c8c9bcef0e8db751630accc04ad874f54e7 disabled the debug support plugin for Windows targets, but what we would actually want is to disable it on Windows HOSTS.
With the new patch here, I don't do exactly that, but instead follow the approach for the EH frame plugin and include the `-noexec` flag in the condition. It should have the desired effect when it comes to the test suite. It appears a little workaround'ish, but should work reliably for now. I will discuss the issue with Lang and see if we can do better. Thanks @thakis again for the temporary fix.
More information about the All-commits
mailing list