[all-commits] [llvm/llvm-project] 116873: [lld-macho][nfc] Parse more options using getLastA...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1168736c668872d7e0000a64daf63dff1c242f80
      https://github.com/llvm/llvm-project/commit/1168736c668872d7e0000a64daf63dff1c242f80
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-03 (Wed, 03 Mar 2021)

  Changed paths:
    M lld/MachO/Driver.cpp

  Log Message:
  -----------
  [lld-macho][nfc] Parse more options using getLastArg{Value}

The option-iterating loop should be reserved for options whose command-line
order is important. I think LLD-ELF follows a similar design.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D97797


  Commit: b63919e18001500c1b549ae0ce2440944e1df8e7
      https://github.com/llvm/llvm-project/commit/b63919e18001500c1b549ae0ce2440944e1df8e7
  Author: Jez Ng <jezng at fb.com>
  Date:   2021-03-03 (Wed, 03 Mar 2021)

  Changed paths:
    M lld/MachO/Driver.cpp
    M lld/MachO/InputFiles.cpp
    M lld/test/MachO/lit.local.cfg
    M lld/test/MachO/syslibroot.test

  Log Message:
  -----------
  [lld-macho] Require -arch and -platform_version to always be specified

We previously defaulted to x86_64 and an unknown platform, which was fine when
we only supported one arch and did no platform checks, but that will no longer
be true going ahead. Therefore, we should require those flags to be specified
whenever the linker is invoked.

Note that LLD-ELF and ld64 both infer the arch from their input object files,
but the usefulness of that is questionable since clang will always specify these
flags, and most of the time `lld` will be invoked via clang.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D97799


Compare: https://github.com/llvm/llvm-project/compare/58d531fd6f04...b63919e18001