[all-commits] [llvm/llvm-project] 5826aa: Migrate to llvm::unique_function instead of static...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Tue Mar 2 16:14:28 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5826aa48f03fba215b135f3c21ee52662281134d
      https://github.com/llvm/llvm-project/commit/5826aa48f03fba215b135f3c21ee52662281134d
  Author: Neal (nealsid) <nealsid at icloud.com>
  Date:   2021-03-02 (Tue, 02 Mar 2021)

  Changed paths:
    M lldb/include/lldb/Core/IOHandler.h
    M lldb/include/lldb/Host/Editline.h
    M lldb/source/Core/IOHandler.cpp
    M lldb/source/Host/common/Editline.cpp
    M lldb/unittests/Editline/EditlineTest.cpp

  Log Message:
  -----------
  Migrate to llvm::unique_function instead of static member functions for callbacks

A few cleanups suggested in another patch review's comments:

1. Use llvm:unique_function for storing & invoking callbacks from
   Editline to IOHandler
2. Change return type of one of the callback setters from bool to void,
   since it's return value was never used
3. Moved the callback setters inline & made them nonstatic, since that's
   more consistent with other setter definitions
4. Removed the baton parameter since we no longer need it anymore

Differential revision: https://reviews.llvm.org/D50299


  Commit: f46a441b1c5dfb0a2580f656e1506fa138f21165
      https://github.com/llvm/llvm-project/commit/f46a441b1c5dfb0a2580f656e1506fa138f21165
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-03-02 (Tue, 02 Mar 2021)

  Changed paths:
    M lldb/docs/use/python-reference.rst

  Log Message:
  -----------
  [lldb] Extend Python convenience variable table with equivalent APIs

Add a column to the table of convenience variables with the equivalent
API to get to the current debugger, target, process, etc.

We often get asked to make convenience variables available outside of
the interactive interpreter. After explaining why that's not possible, a
common complaint is that it's hard to find out how to get to these
variables in a non-interactive context, for example how to get to the
current frame when given a thread. This patch aims to alleviate that by
including the APIs to navigate between these instances in the table.

Differential revision: https://reviews.llvm.org/D97778


Compare: https://github.com/llvm/llvm-project/compare/99f1e86cbb34...f46a441b1c5d


More information about the All-commits mailing list