[all-commits] [llvm/llvm-project] 34ee3d: [libcxx] [test] Pass some windows environment vari...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue Mar 2 12:42:02 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34ee3d91a80cd58ee2ae5309b24ea1b72c3a7b79
      https://github.com/llvm/llvm-project/commit/34ee3d91a80cd58ee2ae5309b24ea1b72c3a7b79
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-03-02 (Tue, 02 Mar 2021)

  Changed paths:
    M libcxx/utils/run.py

  Log Message:
  -----------
  [libcxx] [test] Pass some windows environment variables through to test processes

Normally, the run.py wrapper script runs the child processes in
a clean environment, with only the environment variables available
that are passed via the --env parameter.

However, the COMSPEC and TEMP variables are kind of necessary when
running some tests; COMSPEC is necessary for finding the interpreter
when executing commands via std::system().

Before f1a96de1bc8db527b5eb820c36c17e275900ca2b, tests were executed
via an intermediate shell which implicitly readded the COMSPEC variable.

The TEMP variable allows temp files to be placed in a sensible
location; if unset, they're placed in the default temp fallback of
C:\Windows instead.

Differential Revision: https://reviews.llvm.org/D97452




More information about the All-commits mailing list