[all-commits] [llvm/llvm-project] bf935a: [clangd] Make categorical features 64 bit in Decis...

Utkarsh Saxena via All-commits all-commits at lists.llvm.org
Tue Mar 2 07:27:09 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bf935a034b345e905907c80030c67ef8f737d56a
      https://github.com/llvm/llvm-project/commit/bf935a034b345e905907c80030c67ef8f737d56a
  Author: Utkarsh Saxena <usx at google.com>
  Date:   2021-03-02 (Tue, 02 Mar 2021)

  Changed paths:
    M clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp
    M clang-tools-extra/clangd/quality/CompletionModelCodegen.py

  Log Message:
  -----------
  [clangd] Make categorical features 64 bit in DecisionForest Model.

CodeCompletionContext::Kind has 36 Kinds. The completion model used to
support categorical features of 32 cardinality.
Due to this clangd tests were failing asan tests due to overflow.

This patch makes the completion model support 64 cardinality of
categorical features by storing ENUM Features as uint64_t instead of
uint32_t.

Verified that this fixes the asan failures.

Latency: 6.7ms (old) VS 6.8ms (new) per 1000 predictions.

Differential Revision: https://reviews.llvm.org/D97770




More information about the All-commits mailing list