[all-commits] [llvm/llvm-project] 82289a: [clang-tidy] Remove OptionError

[Nathan James via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 82289aa6c88ad9840369db294cc66ed829e8c435
      https://github.com/llvm/llvm-project/commit/82289aa6c88ad9840369db294cc66ed829e8c435
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
    M clang-tools-extra/clang-tidy/ClangTidyCheck.h
    M clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
    M clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp

  Log Message:
  -----------
  [clang-tidy] Remove OptionError

The interface served a purpose, but since the ability to emit diagnostics when parsing configuration was added, its become mostly redundant. Emitting the diagnostic and removing the boilerplate is much cleaner.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D97614