[all-commits] [llvm/llvm-project] b4bfe2: AArch64/GlobalISel: Fix using wrong calling conven...
Matt Arsenault via All-commits
all-commits at lists.llvm.org
Mon Mar 1 06:10:40 PST 2021
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: b4bfe29415ba9524f56d4ea57eb3adbdb4a82fc9
https://github.com/llvm/llvm-project/commit/b4bfe29415ba9524f56d4ea57eb3adbdb4a82fc9
Author: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: 2021-03-01 (Mon, 01 Mar 2021)
Changed paths:
M llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
Log Message:
-----------
AArch64/GlobalISel: Fix using wrong calling convention for calls
This was reusing the parent function calling convention instead of the
callee. I'm not sure if there's a case where there's an observable
difference.
I previously missed this in b72a23650f573299aec30846fb844c3558921fb8
Commit: 6c260d3bc059b29aa62b91378be4afa2d98d8067
https://github.com/llvm/llvm-project/commit/6c260d3bc059b29aa62b91378be4afa2d98d8067
Author: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: 2021-03-01 (Mon, 01 Mar 2021)
Changed paths:
M llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
M llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
M llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
M llvm/lib/Target/AArch64/GISel/AArch64CallLowering.h
M llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
M llvm/lib/Target/AMDGPU/AMDGPUCallLowering.h
M llvm/lib/Target/ARM/ARMCallLowering.cpp
M llvm/lib/Target/ARM/ARMCallLowering.h
M llvm/lib/Target/Mips/MipsCallLowering.cpp
M llvm/lib/Target/X86/X86CallLowering.cpp
Log Message:
-----------
GlobalISel: Move splitToValueTypes to generic code
I copied the nearly identical function from AArch64 into AMDGPU, so
fix this duplication.
Mips and X86 have their own more exotic versions which should be
removed. However replacing those is better left for a separate patch
since it requires other changes to avoid regressions.
Compare: https://github.com/llvm/llvm-project/compare/f870c551f090...6c260d3bc059
More information about the All-commits
mailing list