[all-commits] [llvm/llvm-project] 1a721b: [clang-tidy][NFC] Tweak some generation of diag me...

[Nathan James via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a721b6a2634d9740b389a7604275b426c22600a
      https://github.com/llvm/llvm-project/commit/1a721b6a2634d9740b389a7604275b426c22600a
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2021-02-26 (Fri, 26 Feb 2021)

  Changed paths:
    M clang-tools-extra/clang-tidy/abseil/DurationFactoryFloatCheck.cpp
    M clang-tools-extra/clang-tidy/abseil/StringFindStartswithCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp
    M clang-tools-extra/clang-tidy/bugprone/ParentVirtualCallCheck.cpp
    M clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
    M clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp
    M clang-tools-extra/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp
    M clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseNodiscardCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp
    M clang-tools-extra/clang-tidy/performance/MoveConstructorInitCheck.cpp
    M clang-tools-extra/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp
    M clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp
    M clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
    M clang-tools-extra/clang-tidy/portability/SIMDIntrinsicsCheck.cpp
    M clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp
    M clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/misc-uniqueptr-reset-release.cpp

  Log Message:
  -----------
  [clang-tidy][NFC] Tweak some generation of diag messages

Fix up cases where diag is called by piecing together a string in favour of placeholders.
Fix up cases where select could be used instead of duplicating the message for sake of 1 word difference.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D97488