[all-commits] [llvm/llvm-project] 1e1b92: IR: Rename Metadata::ImplicitCode to SubclassData1...

Duncan P. N. Exon Smith via All-commits all-commits at lists.llvm.org
Wed Feb 24 12:57:14 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1e1b92f76de79b934ead3be075aff101bd880392
      https://github.com/llvm/llvm-project/commit/1e1b92f76de79b934ead3be075aff101bd880392
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/include/llvm/IR/Metadata.h

  Log Message:
  -----------
  IR: Rename Metadata::ImplicitCode to SubclassData1, NFC

Metadata::ImplicitCode is a bit shaved off of Metadata::Storage,
currently only in use by the subclass DILocation. However, the bit isn't
reserved for that purpose. Rename it `SubclassData1` to make it clear
that it has nothing to do with Metadata itself (and other subclasses are
free to use it).

As a drive-by, remove an old TODO about exposing bits to subclasses
(looks like that has mostly been done).

No functionality change here.

Differential Revision: https://reviews.llvm.org/D96740




More information about the All-commits mailing list