[all-commits] [llvm/llvm-project] 4631af: [lldb][NFC] Rename the second ValueObjectManager t...

[Raphael Isemann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4631afdeb3c48f63688d3b097643d61de8e48e2b
      https://github.com/llvm/llvm-project/commit/4631afdeb3c48f63688d3b097643d61de8e48e2b
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M lldb/include/lldb/Core/ValueObject.h
    A lldb/include/lldb/Core/ValueObjectUpdater.h
    M lldb/source/Core/CMakeLists.txt
    M lldb/source/Core/IOHandlerCursesGUI.cpp
    M lldb/source/Core/ValueObject.cpp
    A lldb/source/Core/ValueObjectUpdater.cpp

  Log Message:
  -----------
  [lldb][NFC] Rename the second ValueObjectManager to ValueObjectUpdater and remove the dead code

`ValueObject.h` contains the `ValueObject::ValueObjectManager` type which is
just a typedef for the ClusterManager that takes care of the whole ValueObject
memory management. However, there is also `ValueObjectManager` defined in the
same header which is only used in the curses UI implementation and consists
mostly of dead and completely untested code.

This code been around since a while (it was added in 2016 as
8369b28da0750129ababae357bea98940800a0e0), so I think we shouldn't just revert
the whole patch.

Instead this patch just moves the class to its own header that it isn't just
hiding in the ValueObject header and renames it to `ValueObjectUpdater` that it
at least has a unique name (which I hope also slightly better reflects the
purpose of this class). I also deleted all the dead code branches and functions.

Reviewed By: #lldb, mib, JDevlieghere

Differential Revision: https://reviews.llvm.org/D97287