[all-commits] [llvm/llvm-project] 27830b: [asan] Avoid putting globals in a comdat section w...

[goussepi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27830bc2b1b876b1948bcd8ae7ee62819be69758
      https://github.com/llvm/llvm-project/commit/27830bc2b1b876b1948bcd8ae7ee62819be69758
  Author: Pierre Gousseau <pierre.gousseau at sony.com>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll
    A llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument-section-invalid-c-ident.ll

  Log Message:
  -----------
  [asan] Avoid putting globals in a comdat section when targetting elf.

Putting globals in a comdat for dead-stripping changes the semantic and
can potentially cause false negative odr violations at link time.
If odr indicators are used, we keep the comdat sections, as link time
odr violations will be dectected for the odr indicator symbols.

This fixes PR 47925