[all-commits] [llvm/llvm-project] 075539: [LLD] [COFF] Allow invoking lib.exe mode via -lib ...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed Feb 24 01:20:54 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 075539ddf6525f5dac31d9b5506cd58c44108633
      https://github.com/llvm/llvm-project/commit/075539ddf6525f5dac31d9b5506cd58c44108633
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/test/COFF/driver.test
    M lld/test/COFF/guardcf-lto.ll

  Log Message:
  -----------
  [LLD] [COFF] Allow invoking lib.exe mode via -lib in addition to /lib

Remove a stray -lib argument in guardcf-lto.ll; llvm-lib doesn't
support generating import libs from a def file unlike lib.exe.
Previously this worked because the -lib argument was ignored
(printing only a warning).

Differential Revision: https://reviews.llvm.org/D96699


  Commit: 90232b2ecd72422fbaad5ea53679f27f59249d95
      https://github.com/llvm/llvm-project/commit/90232b2ecd72422fbaad5ea53679f27f59249d95
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-24 (Wed, 24 Feb 2021)

  Changed paths:
    M libcxx/utils/libcxx/test/config.py

  Log Message:
  -----------
  [libcxx] [test] Don't pass INCLUDE to clang via -isystem

Passing the MSVC include dirs via -isystem makes them included before
clang's own include resource dir (<prefix>/lib/clang/<version>/include).
This causes includes of stddef.h to bypass clang's stddef.h which
defines max_align_t, which libc++ needs defined.

This was added in 4372f06d0fcaba1a6913e2f37be064e06a7b5b5b when the
initial windows testing support was added, and has been brought along
since. It's unclear if this was needed back then - now it no longer is
needed at least, and since libc++ started depending on max_align_t, this
became an issue.

Differential Revision: https://reviews.llvm.org/D97167


Compare: https://github.com/llvm/llvm-project/compare/03892a27d6b8...90232b2ecd72


More information about the All-commits mailing list