[all-commits] [llvm/llvm-project] b6876d: [CMake][profile] Don't use `TARGET lld` to avoid o...

Petr Hosek via All-commits all-commits at lists.llvm.org
Mon Feb 22 23:33:51 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b6876ddc82323ba1527acfd5004be39d594652ff
      https://github.com/llvm/llvm-project/commit/b6876ddc82323ba1527acfd5004be39d594652ff
  Author: Petr Hosek <phosek at google.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M compiler-rt/test/profile/CMakeLists.txt

  Log Message:
  -----------
  [CMake][profile] Don't use `TARGET lld` to avoid ordering issues

Depending on the order in which lld and compiler-rt projects are
processed by CMake, `TARGET lld` might evaluate to `TRUE` or `FALSE`
even though `lld-available` lit stanza is always set because lld is
being built. We check whether lld project is enabled instead which
is used by other compiler-rt tests.

The ideal solution here would be to use CMake generator expressions,
but those cannot be used for dependencies yet, see:
https://gitlab.kitware.com/cmake/cmake/-/issues/19467

Differential Revision: https://reviews.llvm.org/D97256




More information about the All-commits mailing list