[all-commits] [llvm/llvm-project] 99f351: Reland "[mlir] add support for verification in int...

[Tobias Gysi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 99f3510b413768d8e5a7ad06af5e127ba7fee331
      https://github.com/llvm/llvm-project/commit/99f3510b413768d8e5a7ad06af5e127ba7fee331
  Author: Tobias Gysi <tobias.gysi at gmail.com>
  Date:   2021-02-14 (Sun, 14 Feb 2021)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/RunnerUtils.h
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major_as_row_major.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_i8_i8_i32.mlir
    M mlir/lib/ExecutionEngine/RunnerUtils.cpp

  Log Message:
  -----------
  Reland "[mlir] add support for verification in integration tests"

The patch extends the runner utils by verification methods that compare two memrefs. The methods compare the content of the two memrefs and print success if the data is identical up to a small numerical error. The methods are meant to simplify the development of integration tests that compare the results against a reference implementation (cf. the updates to the linalg matmul integration tests).

Originally landed in 5fa893c (https://reviews.llvm.org/D96326) and reverted in dd719fd due to a Windows build failure.

Changes:
- Remove the max function that requires the "algorithm" header on Windows
- Eliminate the truncation warning in the float specialization of verifyElem by using a float constant

Reviewed By: Kayjukh

Differential Revision: https://reviews.llvm.org/D96593