[all-commits] [llvm/llvm-project] 776324: [OpenMP] Fix the check for libpsapi for i386

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Feb 12 11:56:24 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77632422bcca9800fe4733f470f1939db029c0ba
      https://github.com/llvm/llvm-project/commit/77632422bcca9800fe4733f470f1939db029c0ba
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/cmake/LibompHandleFlags.cmake
    M openmp/runtime/cmake/config-ix.cmake

  Log Message:
  -----------
  [OpenMP] Fix the check for libpsapi for i386

check_library_exists fails for stdcall functions, because that
check doesn't include the necessary headers (and thus fails with
an undefined reference to _EnumProcessModules, when the import
library symbol actually is called _EnumProcessModules at 16).

Merge the two previous checks check_include_files and
check_library_exists into one with check_c_source_compiles, and
merge the variables that indicate whether it succeeded.

Differential Revision: https://reviews.llvm.org/D96580


  Commit: 3f9519b768ebe7a2731443bdc2d3178a005e8d7f
      https://github.com/llvm/llvm-project/commit/3f9519b768ebe7a2731443bdc2d3178a005e8d7f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/src/z_Windows_NT_util.cpp

  Log Message:
  -----------
  [OpenMP] Only use #pragma comment(lib, ...) in MSVC build configurations

MinGW build configurations don't support this pragma (unless
compiling with clang, with -fms-extensions, and linking with
lld), and at least clang warns about it.

This library does end up linked by the cmake files anyway (as
long as the check works properly).

Differential Revision: https://reviews.llvm.org/D96581


  Commit: b3d84790faadaff95bd32ae9950205e044f6fce0
      https://github.com/llvm/llvm-project/commit/b3d84790faadaff95bd32ae9950205e044f6fce0
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/src/kmp_affinity.cpp
    M openmp/runtime/src/kmp_atomic.cpp
    M openmp/runtime/src/kmp_io.cpp
    M openmp/runtime/src/kmp_tasking.cpp
    M openmp/runtime/src/z_Windows_NT_util.cpp

  Log Message:
  -----------
  [OpenMP] Add void casts to silence unused variable warnings

These variables are used only in certain build configurations,
or marked with a todo comment indicating that they should be
used/checked/reported.

Differential Revision: https://reviews.llvm.org/D96582


  Commit: b388c84c096b3810382d34e1e7438bd4bfcf2123
      https://github.com/llvm/llvm-project/commit/b388c84c096b3810382d34e1e7438bd4bfcf2123
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/src/z_Windows_NT_util.cpp

  Log Message:
  -----------
  [OpenMP] Remove two entirely unused variables

Differential Revision: https://reviews.llvm.org/D96583


  Commit: 16428a8d91a904c841086a971a8f26c3d8cf1307
      https://github.com/llvm/llvm-project/commit/16428a8d91a904c841086a971a8f26c3d8cf1307
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/src/kmp_environment.cpp
    M openmp/runtime/src/kmp_io.cpp

  Log Message:
  -----------
  [OpenMP] Avoid warnings about unused static functions on windows

Add ifdefs around one function that only is used in unix build
configurations.

Add a void cast for a windows specific function that currently is
unused but may be intended to be used at some point.

Differential Revision: https://reviews.llvm.org/D96584


  Commit: 496ca4127e2733d8421af70d360cd5df779fe592
      https://github.com/llvm/llvm-project/commit/496ca4127e2733d8421af70d360cd5df779fe592
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M openmp/runtime/cmake/LibompHandleFlags.cmake
    M openmp/runtime/cmake/config-ix.cmake

  Log Message:
  -----------
  [OpenMP] Silence more warning flags

This silences warnings like these, in mingw builds with clang:

runtime/src/kmp_atomic.h:1021:13: warning: '__kmpc_atomic_cmplx8_rd' has C-linkage specified, but returns user-defined type 'kmp_cmplx64' (aka '__kmp_cmplx64_t') which is incompatible with C [-Wreturn-type-c-linkage]

runtime/src/z_Windows_NT_util.cpp:479:17: warning: cast from 'volatile void *' to 'type-parameter-0-0 *' drops volatile qualifier [-Wcast-qual]
    flag = (C *)th->th.th_sleep_loc;

runtime/src/z_Windows_NT_util.cpp:1321:14: warning: cast to 'void *' from smaller integer type 'DWORD' (aka 'unsigned long') [-Wint-to-void-pointer-cast]
  } else if ((void *)exit_val != (void *)th) {

Differential Revision: https://reviews.llvm.org/D96585


Compare: https://github.com/llvm/llvm-project/compare/3c06676de14d...496ca4127e27


More information about the All-commits mailing list