[all-commits] [llvm/llvm-project] 0c1188: [lldb] Let TestPExpectTest test the right test class

Raphael Isemann via All-commits all-commits at lists.llvm.org
Fri Feb 12 00:57:18 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c118831a37a058f5ff196a4be3c4d5b1cf25e63
      https://github.com/llvm/llvm-project/commit/0c118831a37a058f5ff196a4be3c4d5b1cf25e63
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbpexpect.py
    M lldb/test/API/test_utils/TestPExpectTest.py

  Log Message:
  -----------
  [lldb] Let TestPExpectTest test the right test class

This test supposed to check the test base we are using for pexpect tests, but instead it used the normal TestBase
class we use for all other tests. TestBase already had the substrs type check since D88792 so this
test was passing because of that.

This just changes the test base of the test to the pexpect one so that the `expect` calls find their intended
target function. Also moves the check to the very start so that we can check the argument without
actually having to start a terminal and all that jazz.

(I found this by accident as D88792 got somehow reverted in a downstream branch so this test started
failing).

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D96556




More information about the All-commits mailing list