[all-commits] [llvm/llvm-project] 8043d5: NFC: update clang tests to check ordering and alig...

James Y Knight via All-commits all-commits at lists.llvm.org
Thu Feb 11 14:35:50 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8043d5a9643b5731454fce91fac0018bfddc96d6
      https://github.com/llvm/llvm-project/commit/8043d5a9643b5731454fce91fac0018bfddc96d6
  Author: James Y Knight <jyknight at google.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M clang/test/CodeGen/2008-03-05-syncPtr.c
    M clang/test/CodeGen/2010-01-13-MemBarrier.c
    M clang/test/CodeGen/Atomics.c
    M clang/test/CodeGen/RISCV/riscv-atomics.c
    M clang/test/CodeGen/X86/x86-atomic-long_double.c
    M clang/test/CodeGen/X86/x86_64-atomic-128.c
    M clang/test/CodeGen/arm-atomics-m.c
    M clang/test/CodeGen/arm-atomics.c
    M clang/test/CodeGen/arm64-microsoft-intrinsics.c
    M clang/test/CodeGen/atomic-ops.c
    M clang/test/CodeGen/atomic.c
    M clang/test/CodeGen/atomic_ops.c
    M clang/test/CodeGen/atomics-inlining.c
    M clang/test/CodeGen/big-atomic-ops.c
    M clang/test/CodeGen/bittest-intrin.c
    M clang/test/CodeGen/builtins-nvptx-ptx50.cu
    M clang/test/CodeGen/builtins-nvptx.c
    M clang/test/CodeGen/c11atomics-ios.c
    M clang/test/CodeGen/c11atomics.c
    M clang/test/CodeGen/code-coverage-tsan.c
    M clang/test/CodeGen/linux-arm-atomic.c
    M clang/test/CodeGen/ms-intrinsics-other.c
    M clang/test/CodeGen/ms-intrinsics.c
    M clang/test/CodeGen/ms-volatile.c
    M clang/test/CodeGen/pr45476.cpp
    M clang/test/CodeGenCXX/atomic-align.cpp
    M clang/test/CodeGenCXX/atomic-inline.cpp
    M clang/test/CodeGenCXX/atomic.cpp
    M clang/test/CodeGenCXX/atomicinit.cpp
    M clang/test/CodeGenCXX/cxx1z-decomposition.cpp
    M clang/test/CodeGenCXX/cxx1z-inline-variables.cpp
    M clang/test/CodeGenCXX/static-init-pnacl.cpp
    M clang/test/CodeGenCXX/static-init.cpp
    M clang/test/CodeGenCXX/static-initializer-branch-weights.cpp
    M clang/test/CodeGenObjC/property-atomic-bool.m
    M clang/test/CodeGenOpenCL/atomic-ops.cl
    M clang/test/OpenMP/atomic_capture_codegen.cpp
    M clang/test/OpenMP/atomic_codegen.cpp
    M clang/test/OpenMP/atomic_read_codegen.c
    M clang/test/OpenMP/atomic_update_codegen.cpp
    M clang/test/OpenMP/atomic_write_codegen.c
    M clang/test/OpenMP/for_reduction_codegen.cpp
    M clang/test/OpenMP/parallel_for_lastprivate_conditional.cpp
    M clang/test/OpenMP/parallel_master_codegen.cpp
    M clang/test/OpenMP/parallel_reduction_codegen.cpp
    M clang/test/OpenMP/requires_acq_rel_codegen.cpp
    M clang/test/OpenMP/requires_relaxed_codegen.cpp
    M clang/test/OpenMP/requires_seq_cst_codegen.cpp
    M clang/test/OpenMP/sections_reduction_codegen.cpp
    M clang/test/OpenMP/target_teams_distribute_parallel_for_reduction_codegen.cpp
    M clang/test/OpenMP/target_teams_distribute_parallel_for_simd_reduction_codegen.cpp
    M clang/test/OpenMP/target_teams_distribute_reduction_codegen.cpp
    M clang/test/OpenMP/target_teams_distribute_simd_reduction_codegen.cpp
    M clang/test/OpenMP/taskloop_with_atomic_codegen.cpp
    M clang/test/OpenMP/teams_distribute_parallel_for_reduction_codegen.cpp
    M clang/test/OpenMP/teams_distribute_parallel_for_simd_reduction_codegen.cpp
    M clang/test/OpenMP/teams_distribute_reduction_codegen.cpp
    M clang/test/OpenMP/teams_distribute_simd_reduction_codegen.cpp

  Log Message:
  -----------
  NFC: update clang tests to check ordering and alignment for atomicrmw/cmpxchg.

The ability to specify alignment was recently added, and it's an
important property which we should ensure is set as expected by
Clang. (Especially before making further changes to Clang's code in
this area.) But, because it's on the end of the lines, the existing
tests all ignore it.

Therefore, update all the tests to also verify the expected alignment
for atomicrmw and cmpxchg. While I was in there, I also updated uses
of 'load atomic' and 'store atomic', and added the memory ordering,
where that was missing.




More information about the All-commits mailing list