[all-commits] [llvm/llvm-project] 60bed4: Replace deprecated %T in 2 tests.

abidh via All-commits all-commits at lists.llvm.org
Thu Feb 11 14:22:05 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60bed4ab57d562d5770cc9c24a8fcb243208f5e5
      https://github.com/llvm/llvm-project/commit/60bed4ab57d562d5770cc9c24a8fcb243208f5e5
  Author: Hafiz Abid Qadeer <abidh at codesourcery.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M clang/test/Driver/riscv32-toolchain-extra.c
    M clang/test/Driver/riscv64-toolchain-extra.c

  Log Message:
  -----------
  Replace deprecated %T in 2 tests.

In D91442, @MaskRay commented about a failure. This commit does the following to
address his comments:

1. Replace %T with %t as former is deprecated.
2. Add an explicit --sysroot argument in a test.

Some tests were failing when gcc-10-riscv64-linux-gnu is installed on test machine.
This was happening because the test was checking a case when --gcc-toolchain is not
provided. But if --sysroot was also not provided then code could pick a toolchain
installed in /usr. So to make the test more robust, I have provided an explicit --sysroot
argument. Its value has been chosen to match the existing patterns.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D93023




More information about the All-commits mailing list