[all-commits] [llvm/llvm-project] 9a08f7: [mlir] Make JitRunnerMain main take a DialectRegistry

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9a08f760fe37094b6181c81575cd19f280dbbff5
      https://github.com/llvm/llvm-project/commit/9a08f760fe37094b6181c81575cd19f280dbbff5
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/JitRunner.h
    M mlir/lib/ExecutionEngine/JitRunner.cpp
    M mlir/tools/mlir-cpu-runner/CMakeLists.txt
    M mlir/tools/mlir-cpu-runner/mlir-cpu-runner.cpp
    M mlir/tools/mlir-cuda-runner/CMakeLists.txt
    M mlir/tools/mlir-cuda-runner/mlir-cuda-runner.cpp
    M mlir/tools/mlir-rocm-runner/CMakeLists.txt
    M mlir/tools/mlir-rocm-runner/mlir-rocm-runner.cpp
    M mlir/tools/mlir-spirv-cpu-runner/CMakeLists.txt
    M mlir/tools/mlir-spirv-cpu-runner/mlir-spirv-cpu-runner.cpp
    M mlir/tools/mlir-vulkan-runner/CMakeLists.txt
    M mlir/tools/mlir-vulkan-runner/mlir-vulkan-runner.cpp

  Log Message:
  -----------
  [mlir] Make JitRunnerMain main take a DialectRegistry

Historically, JitRunner has been registering all available dialects with the
context and depending on them without the real need. Make it take a registry
that contains only the dialects that are expected in the input and stop linking
in all dialects.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D96436


  Commit: 0881a4f1bf769a588e7d6d6af8501a230a2f42c8
      https://github.com/llvm/llvm-project/commit/0881a4f1bf769a588e7d6d6af8501a230a2f42c8
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/tools/mlir-tblgen/LLVMIRConversionGen.cpp

  Log Message:
  -----------
  [mlir] make ModuleTranslation mapping fields private

ModuleTranslation contains multiple fields that keep track of the mappings
between various MLIR and LLVM IR components. The original ModuleTranslation
extension model was based on inheritance, with these fields being protected and
thus accessible in the ModuleTranslation and derived classes. The
inheritance-based model doesn't scale to translation of more than one derived
dialect and will be progressively replaced with a more flexible one based on
dialect interfaces and a translation state that is separate from
ModuleTranslation. This change prepares the replacement by making the mappings
private and providing public methods to access them.

Depends On D96436

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D96437


Compare: https://github.com/llvm/llvm-project/compare/81a970772384...0881a4f1bf76