[all-commits] [llvm/llvm-project] 23753c: [Polly] Hide Simplify implementation from header. ...

Michael Kruse via All-commits all-commits at lists.llvm.org
Wed Feb 10 20:13:29 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 23753c6088873f01fd32c6f3e3bd03ec7c2f8588
      https://github.com/llvm/llvm-project/commit/23753c6088873f01fd32c6f3e3bd03ec7c2f8588
  Author: Michael Kruse <llvm-project at meinersbur.de>
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
    M polly/include/polly/Simplify.h
    M polly/lib/Transform/Simplify.cpp

  Log Message:
  -----------
  [Polly] Hide Simplify implementation from header. NFC.

Move SimplifiyVisitor from Simplify.h to Simplify.cpp. It is not
relevant for applying the pass in either the NewPM or the legacyPM.
Rename it to SimplifyImpl to account for that.

This is possible due its state not being necessary to be preserved
between runs and thefore SimplifyImpl not needed to be held in the
pass object. Instead, SimplifyImpl is only instatiated for the
current Scop. In the NewPM as a function-local variable, and in the
legacy PM inside a llvm::Optional object because the state must be
preserved between the printScop (invoked by opt -analyze) and the most
recent runOnScop calls.




More information about the All-commits mailing list