[all-commits] [llvm/llvm-project] 018645: Fix side-effect detection in LLVMIRIntrinsicGen.

Andrew Pritchard via All-commits all-commits at lists.llvm.org
Tue Feb 9 16:48:41 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 018645b81b3bc4485bae8e9bc6e904ecd4c4a5ec
      https://github.com/llvm/llvm-project/commit/018645b81b3bc4485bae8e9bc6e904ecd4c4a5ec
  Author: Andrew Pritchard <awpr at google.com>
  Date:   2021-02-10 (Wed, 10 Feb 2021)

  Changed paths:
    M mlir/test/mlir-tblgen/llvm-intrinsics.td
    M mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp

  Log Message:
  -----------
  Fix side-effect detection in LLVMIRIntrinsicGen.

Previously it reported an op had side-effects iff it declared that it
didn't have any side-effects.  This had the undesirable result that
canonicalization would always delete any intrinsic calls that did memory
stores and returned void.

Reviewed By: ftynse, mehdi_amini

Differential Revision: https://reviews.llvm.org/D96369




More information about the All-commits mailing list