[all-commits] [llvm/llvm-project] 4756f7: [libomptarget][amdgcn] Tolerate deadstripped env v...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Tue Feb 9 03:59:02 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4756f76bce7835dd233c82637bf60082469f9320
      https://github.com/llvm/llvm-project/commit/4756f76bce7835dd233c82637bf60082469f9320
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2021-02-09 (Tue, 09 Feb 2021)

  Changed paths:
    M openmp/libomptarget/plugins/amdgpu/src/rtl.cpp

  Log Message:
  -----------
  [libomptarget][amdgcn] Tolerate deadstripped env variable

[libomptarget][amdgcn] Tolerate deadstripped env variable

Discovered by Pushpinder. If the device_environment variable is unused
it can be deadstripped, in which case we should not abort due to it
missing. This change is safe in that a missing symbol which is actually
used can be reported by both linker and loader, and a missing unused
symbol is better deadstripped than left in the image.

Reviewed By: pdhaliwal

Differential Revision: https://reviews.llvm.org/D96329




More information about the All-commits mailing list