[all-commits] [llvm/llvm-project] c945dc: PR48587: is_constant_evaluated() should not evalua...

[Richard Smith via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c945dc4a5023d6a17d11fcda76509b94b36e34fc
      https://github.com/llvm/llvm-project/commit/c945dc4a5023d6a17d11fcda76509b94b36e34fc
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M clang/lib/AST/ExprConstant.cpp
    M clang/test/CodeGenCXX/builtin-is-constant-evaluated.cpp

  Log Message:
  -----------
  PR48587: is_constant_evaluated() should not evaluate to true during a
variable's destruction if it didn't do so during construction.

The standard doesn't give any guidance as to what to do here, but this
approach seems reasonable and conservative, and has been proposed to the
standard committee.