[all-commits] [llvm/llvm-project] 622611: [TableGen] Use return value from EmitVBRValue inst...

Craig Topper via All-commits all-commits at lists.llvm.org
Mon Feb 8 16:37:31 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 622611f7e5b2c42ad3c34aec4a77a82adf6d9e36
      https://github.com/llvm/llvm-project/commit/622611f7e5b2c42ad3c34aec4a77a82adf6d9e36
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M llvm/utils/TableGen/DAGISelMatcherEmitter.cpp

  Log Message:
  -----------
  [TableGen] Use return value from EmitVBRValue instead of calling GetVBRSize on the same value. Consistently use unsigned for child sizes. NFCI

getSize and setSize both use unsigned. So size_t doesn't
increase range here and might get truncated if passed to
setSize.

Also not sure why EmitVBRValue was returning uint64_t, but used
an unsigned to supply the value.




More information about the All-commits mailing list