[all-commits] [llvm/llvm-project] 71c29b: [AArch64] Use '//' as comment string for MSVC asse...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Feb 8 12:30:40 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 71c29b4cf3fb2b5610991bfbc12b8bda97d60005
      https://github.com/llvm/llvm-project/commit/71c29b4cf3fb2b5610991bfbc12b8bda97d60005
  Author: Martin Storsjö <martin at martin.st>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
    M llvm/test/CodeGen/AArch64/cfguard-checks.ll
    M llvm/test/CodeGen/AArch64/landingpad-ifcvt.ll
    M llvm/test/CodeGen/AArch64/reloc-specifiers.mir
    M llvm/test/CodeGen/AArch64/seh_funclet_x1.ll
    M llvm/test/CodeGen/AArch64/win64-no-uwtable.ll
    M llvm/test/CodeGen/AArch64/windows-extern-weak.ll
    M llvm/test/CodeGen/AArch64/wineh-try-catch-nobase.ll
    M llvm/test/CodeGen/AArch64/wineh-try-catch.ll
    R llvm/test/MC/AArch64/coff-gnu.s
    M llvm/test/MC/AArch64/coff-relocations.s
    A llvm/test/MC/AArch64/coff-separator.s

  Log Message:
  -----------
  [AArch64] Use '//' as comment string for MSVC assembly

As the actual MSVC toolset doesn't use the GAS-style assembly that
Clang/LLVM produces and consumes, there's no reference for what
string to use for e.g. comments when building with a MSVC triple.

This frees up the use of semicolon as separator string, just like
was done for GNU targets in 23413195649d0cf6f3860ae8b5fb115b35032075.
(Previously, both the separator and comment strings were set to
the same, a semicolon.)

Compiler-rt extensively uses separator chars in its assembly,
and that assembly should be buildable with clang-cl for MSVC too.

Differential Revision: https://reviews.llvm.org/D96259




More information about the All-commits mailing list