[all-commits] [llvm/llvm-project] 6f4f0e: [X86] Don't pass a 1 to the second argument of ISD...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6f4f0efd893de87fd9aaea379165a8ae566a9096
      https://github.com/llvm/llvm-project/commit/6f4f0efd893de87fd9aaea379165a8ae566a9096
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-02-06 (Sat, 06 Feb 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Don't pass a 1 to the second argument of ISD::FP_ROUND in LowerFCOPYSIGN.

I don't think we have any reason to believe the FP_ROUND here doesn't change the value.

Found while trying to see if we still need the fp128 block in CanCombineFCOPYSIGN_EXTEND_ROUND.
Removing that check caused this FP_ROUND to fire for fp128 which introduced a libcall expansion that asserted for this being a 1.

Reviewed By: RKSimon, pengfei

Differential Revision: https://reviews.llvm.org/D96098