[all-commits] [llvm/llvm-project] 716eef: [OpenMP][libomptarget] Fixed an issue that device ...
Shilei Tian via All-commits
all-commits at lists.llvm.org
Fri Feb 5 20:47:59 PST 2021
Branch: refs/heads/release/12.x
Home: https://github.com/llvm/llvm-project
Commit: 716eef9ad5b367e5cbcc22c8ac53395f9bdbe7a5
https://github.com/llvm/llvm-project/commit/716eef9ad5b367e5cbcc22c8ac53395f9bdbe7a5
Author: Shilei Tian <tianshilei1992 at gmail.com>
Date: 2021-02-05 (Fri, 05 Feb 2021)
Changed paths:
M openmp/libomptarget/src/omptarget.cpp
A openmp/libomptarget/test/offloading/assert.cpp
Log Message:
-----------
[OpenMP][libomptarget] Fixed an issue that device sync is skipped if the kernel doesn't have any argument
Currently if there is not kernel argument, device synchronization will
be skipped. This can lead to two issues:
1. If there is any device error, it will not be captured;
2. The target region might end before the kernel is done, which is not spec
conformant.
The test added in this patch only runs on NVPTX platform, although it will not
be executed by Phab at all. It also requires `not` which is not available on most
systems.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D96067
(cherry picked from commit b68a6b09e60a24733b923a0fc282746a855852da)
More information about the All-commits
mailing list