[all-commits] [llvm/llvm-project] b68a6b: [OpenMP][libomptarget] Fixed an issue that device ...

Shilei Tian via All-commits all-commits at lists.llvm.org
Thu Feb 4 17:14:42 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b68a6b09e60a24733b923a0fc282746a855852da
      https://github.com/llvm/llvm-project/commit/b68a6b09e60a24733b923a0fc282746a855852da
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M openmp/libomptarget/src/omptarget.cpp
    A openmp/libomptarget/test/offloading/assert.cpp

  Log Message:
  -----------
  [OpenMP][libomptarget] Fixed an issue that device sync is skipped if the kernel doesn't have any argument

Currently if there is not kernel argument, device synchronization will
be skipped. This can lead to two issues:
1. If there is any device error, it will not be captured;
2. The target region might end before the kernel is done, which is not spec
   conformant.

The test added in this patch only runs on NVPTX platform, although it will not
be executed by Phab at all. It also requires `not` which is not available on most
systems.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D96067




More information about the All-commits mailing list