[all-commits] [llvm/llvm-project] 63dc26: Revert "[mlir][ODS] Use StringLiteral instead of S...

Lei Zhang via All-commits all-commits at lists.llvm.org
Thu Feb 4 11:00:11 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63dc26450b34312b5fe63fe2dee2b85d5a47b4a6
      https://github.com/llvm/llvm-project/commit/63dc26450b34312b5fe63fe2dee2b85d5a47b4a6
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td
    M mlir/test/mlir-tblgen/op-decl.td
    M mlir/tools/mlir-tblgen/DialectGen.cpp
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/PassGen.cpp

  Log Message:
  -----------
  Revert "[mlir][ODS] Use StringLiteral instead of StringRef when applicable"

This reverts commit 953086ddbb593289fafcf0e7cc6e74847f1635af because
it breaks GCC 5 build:

  error: could not convert '(const char*)""' from 'const char*' to 'llvm::StringLiteral'
     static ::llvm::StringLiteral getDialectNamespace() { return ""; }




More information about the All-commits mailing list