[all-commits] [llvm/llvm-project] 056d31: [ExpandReductions] fix FMF requirement for fmin/fmax

RotateRight via All-commits all-commits at lists.llvm.org
Thu Feb 4 10:36:44 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 056d31dd2a043ecc2baf22b708c8dd95f7c2df35
      https://github.com/llvm/llvm-project/commit/056d31dd2a043ecc2baf22b708c8dd95f7c2df35
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M llvm/lib/CodeGen/ExpandReductions.cpp
    M llvm/test/CodeGen/X86/vector-reduce-fmax-nnan.ll
    M llvm/test/CodeGen/X86/vector-reduce-fmin-nnan.ll
    M llvm/test/Transforms/PhaseOrdering/X86/vector-reductions-expanded.ll

  Log Message:
  -----------
  [ExpandReductions] fix FMF requirement for fmin/fmax

The upstream callers (the vectorizers) were fixed with:
bbed5f2f8a04 ( D95690 )
77adbe6a8c71

We should remove this pass entirely now that reduction
legalization/lowering is expected to work just as well,
but we need to confirm that the shuffle ops do not
regress (for x86 in particular).

This should be the last step needed to close:
https://llvm.org/PR23116




More information about the All-commits mailing list