[all-commits] [llvm/llvm-project] 66c7b4: [OpenMP] Fix building using LLVM_ENABLE_RUNTIMES

Shilei Tian via All-commits all-commits at lists.llvm.org
Thu Feb 4 07:25:34 PST 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 66c7b449acf402bdc87b69db5778b7b43958d217
      https://github.com/llvm/llvm-project/commit/66c7b449acf402bdc87b69db5778b7b43958d217
  Author: Giorgis Georgakoudis <georgakoudis1 at llnl.gov>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M openmp/CMakeLists.txt
    M openmp/runtime/src/CMakeLists.txt

  Log Message:
  -----------
  [OpenMP] Fix building using LLVM_ENABLE_RUNTIMES

Fix when time profiling is enabled.

Related to: D94855

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D95398

(cherry picked from commit bb40e6731843de92f1c73ad6efceb8a89e045ea6)


  Commit: 92a5106e8055bab7da46095a832904444862728b
      https://github.com/llvm/llvm-project/commit/92a5106e8055bab7da46095a832904444862728b
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M openmp/CMakeLists.txt
    M openmp/docs/design/Runtimes.rst
    M openmp/runtime/CMakeLists.txt
    M openmp/runtime/src/CMakeLists.txt
    M openmp/runtime/src/kmp_config.h.cmake
    M openmp/runtime/src/kmp_runtime.cpp

  Log Message:
  -----------
  [OpenMP] Disabled profiling in `libomp` by default to unblock link errors

Link error occurred when time profiling in libomp is enabled by default
because `libomp` is assumed to be a C library but the dependence on
`libLLVMSupport` for profiling is a C++ library. Currently the issue blocks all
OpenMP tests in Phabricator.

This patch set a new CMake option `OPENMP_ENABLE_LIBOMP_PROFILING` to
enable/disable the feature. By default it is disabled. Note that once time
profiling is enabled for `libomp`, it becomes a C++ library.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95585

(cherry picked from commit c571b168349fdf22d1dc8b920bcffa3d5161f0a2)


Compare: https://github.com/llvm/llvm-project/compare/bc2dad167159...92a5106e8055


More information about the All-commits mailing list