[all-commits] [llvm/llvm-project] ba87f9: [mlir] make vector to llvm conversion truly partial

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba87f99168c93461b28a4aa2d05e238ff774d57a
      https://github.com/llvm/llvm-project/commit/ba87f99168c93461b28a4aa2d05e238ff774d57a
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2021-02-04 (Thu, 04 Feb 2021)

  Changed paths:
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major_as_row_major.mlir
    M mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_i8_i8_i32.mlir
    M mlir/integration_test/Dialect/Standard/CPU/test-ceil-floor-pos-neg.mlir
    M mlir/integration_test/Dialect/Vector/CPU/test-transfer-read-2d.mlir
    M mlir/integration_test/Dialect/Vector/CPU/test-transfer-to-loops.mlir
    M mlir/integration_test/Dialect/Vector/CPU/test-vector-distribute.mlir
    M mlir/lib/Conversion/ArmSVEToLLVM/ArmSVEToLLVM.cpp
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
    M mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Conversion/ArmSVEToLLVM/convert-to-llvm.mlir
    M mlir/test/Conversion/VectorToLLVM/vector-mask-to-llvm.mlir
    M mlir/test/Conversion/VectorToLLVM/vector-reduction-to-llvm.mlir
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
    M mlir/test/Dialect/LLVMIR/dialect-cast.mlir
    M mlir/test/Target/vector-to-llvm-ir.mlir

  Log Message:
  -----------
  [mlir] make vector to llvm conversion truly partial

Historically, the Vector to LLVM dialect conversion subsumed the Standard to
LLVM dialect conversion patterns. This was necessary because the conversion
infrastructure did not have sufficient support for reconciling type
conversions. This support is now available. Only keep the patterns related to
the Vector dialect in the Vector to LLVM conversion and require type casts
operations to be inserted if necessary. These casts will be removed by
following conversions if possible. Update integration tests to also run the
Standard to LLVM conversion.

There is a significant amount of test churn, which is due to (a) unnecessarily
strict tests in VectorToLLVM and (b) many patterns actually targeting Standard
dialect ops instead of LLVM dialect ops leading to tests actually exercising a
Vector->Standard->LLVM conversion. This churn is a good illustration of the
reason to make the conversion partial: now the tests only check the code in the
Vector to LLVM conversion and will not be randomly broken by changes in
Standard to LLVM conversion.

Arguably, it may be possible to extract Vector to Standard patterns into a
separate pass, but given the ongoing splitting of the Standard dialect, such
pass will be short-lived and will require further refactoring.

Depends On D95626

Reviewed By: nicolasvasilache, aartbik

Differential Revision: https://reviews.llvm.org/D95685