[all-commits] [llvm/llvm-project] a2c105: [ASTReader] Always rebuild a cached module that ha...

[Ben Barham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a2c1054c303f20be006e9ef20739dbb88bd9ae02
      https://github.com/llvm/llvm-project/commit/a2c1054c303f20be006e9ef20739dbb88bd9ae02
  Author: Ben Barham <ben_barham at apple.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp
    R clang/test/Modules/Inputs/error.h
    A clang/test/Modules/Inputs/error/error.h
    A clang/test/Modules/Inputs/error/module.modulemap
    M clang/test/Modules/Inputs/module.map
    M clang/test/Modules/load-module-with-errors.m

  Log Message:
  -----------
  [ASTReader] Always rebuild a cached module that has errors

A module in the cache with an error should just be a cache miss. If
allowing errors (with -fallow-pcm-with-compiler-errors), a rebuild is
needed so that the appropriate diagnostics are output and in case search
paths have changed. If not allowing errors, the module was built
*allowing* errors and thus should be rebuilt regardless.

Reviewed By: akyrtzi

Differential Revision: https://reviews.llvm.org/D95989