[all-commits] [llvm/llvm-project] 12b657: [OpenMP][Libomptarget] Fix conditional in CMake fo...

Joseph Huber via All-commits all-commits at lists.llvm.org
Wed Feb 3 14:28:56 PST 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 12b6579b79dc21e9e54e74520ece0d571a640d4b
      https://github.com/llvm/llvm-project/commit/12b6579b79dc21e9e54e74520ece0d571a640d4b
  Author: Atmn Patel <atmndp at gmail.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M openmp/libomptarget/plugins/remote/CMakeLists.txt

  Log Message:
  -----------
  [OpenMP][Libomptarget] Fix conditional in CMake for remote plugin

The remote offloading plugin's CMakeLists was trying to build if its
flag was enabled even if it didn't find gRPC/protobuf. The conditional
was wrong, it's fixed by this.

Differential Revision: https://reviews.llvm.org/D95574

(cherry picked from commit 8a77056256d9970387595a5c729d894e3fe07131)


  Commit: 4d0874c72a0a3f53eb3084a1ea3ee4456ab6e004
      https://github.com/llvm/llvm-project/commit/4d0874c72a0a3f53eb3084a1ea3ee4456ab6e004
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt

  Log Message:
  -----------
  [OpenMP][NVPTX] Added the missing -O1 when building NVPTX bitcode libraries

In the past `-O1` was used when building NVPTX bitcode libraries. After
we switched to OpenMP, `-O1` was missing by mistake, leading to a huge performance
regression.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D95545

(cherry picked from commit 5a64794bbad4010778406dfee7748e6080258dbf)


  Commit: 5d926bb3c46848c704833e0f02884395609388a3
      https://github.com/llvm/llvm-project/commit/5d926bb3c46848c704833e0f02884395609388a3
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/common/src/omp_data.cu

  Log Message:
  -----------
  [OpenMP][deviceRTLs] Added `[[clang::loader_uninitialized]]` explicitly

`[[clang::loader_uninitialized]]` is in macro `SHARED` but it doesn't
work for array like `parallelLevel`, so the variable will be zero initialized.
There is also a similar issue for `omptarget_nvptx_device_State` which is in
global address space. Its c'tor is also generated, which was not in the past when
building the `deviceRTLs` with CUDA. In this patch, we added the attribute to
the two variables explicitly.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95550

(cherry picked from commit 19248d30e4ed5250fa84abbbd52fc7b835918a45)


  Commit: 255f7398845a7cfb47aef53e40b68057ec56839e
      https://github.com/llvm/llvm-project/commit/255f7398845a7cfb47aef53e40b68057ec56839e
  Author: Shilei Tian <tianshilei1992 at gmail.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M openmp/docs/ReleaseNotes.rst

  Log Message:
  -----------
  [OpenMP][NFC] Added release note for new `deviceRTLs` and hidden helper task

Added release note for new `deviceRTLs` and hidden helper task for LLVM
12.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95584

(cherry picked from commit 7bc31018f71cac22b7060c49cefb6f3d0d2e2069)


  Commit: 922e4149d16754b54ce225faa3e769d32937d7ad
      https://github.com/llvm/llvm-project/commit/922e4149d16754b54ce225faa3e769d32937d7ad
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M openmp/libomptarget/src/interface.cpp
    M openmp/libomptarget/src/private.h

  Log Message:
  -----------
  [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads

Summary:
One option for the LIBOMPTARGET_INFO environment variable is to print the current status of the device's data mappings. These are a shared resource among threads so this needs to be protected when using multiple streams.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D95786

(cherry picked from commit fda48539988d2a1bdb6395799151e9090312a20b)


Compare: https://github.com/llvm/llvm-project/compare/e2d822c3bdf6...922e4149d167


More information about the All-commits mailing list