[all-commits] [llvm/llvm-project] dd2dac: Fix MLIR Async Runtime DLL on Windows

[Matthew Parkinson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd2dac2fd076b76e2897306ad8f95766ebddf6c3
      https://github.com/llvm/llvm-project/commit/dd2dac2fd076b76e2897306ad8f95766ebddf6c3
  Author: Matthew Parkinson <mattpark at microsoft.com>
  Date:   2021-02-03 (Wed, 03 Feb 2021)

  Changed paths:
    M mlir/include/mlir/ExecutionEngine/AsyncRuntime.h
    M mlir/lib/ExecutionEngine/AsyncRuntime.cpp

  Log Message:
  -----------
  Fix MLIR Async Runtime DLL on Windows

The AsyncRuntime declares prototypes for extern "C" functions inside a
namespace in the header, but not inside that namespace in the
definition. This causes Visual Studio to treat them as different
entities and thus the dllexport is ignored for the definitions.

Using the same namespace fixes this issue.

Secondly, this commit moves the dllexport to be consistent with the
JITs expectation.

This is an update to https://reviews.llvm.org/D95386 that fixes the
compile issues in old versions of Visual studio.

Differential Revision: https://reviews.llvm.org/D95933