[all-commits] [llvm/llvm-project] b54566: [OpenMP][Libomptarget] Remove possible harmful cop...

Atmn Patel via All-commits all-commits at lists.llvm.org
Mon Feb 1 17:13:53 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b545667d0a4e8d3ca7d4789c3c4004b2816c1b84
      https://github.com/llvm/llvm-project/commit/b545667d0a4e8d3ca7d4789c3c4004b2816c1b84
  Author: Atmn Patel <atmndp at gmail.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M openmp/libomptarget/src/interface.cpp

  Log Message:
  -----------
  [OpenMP][Libomptarget] Remove possible harmful copy constructor call for RTLsTy

>From https://bugs.llvm.org/show_bug.cgi?id=48973, we know that
`std::call_once(PM->RTLs.initFlag, &RTLsTy::LoadRTLs, PM->RTLs)` causes compile
time problems in libstdc++v3 5.3.1. This is because there was a defect in the
standard regarding the `call_once` (LWG 2442). This was fixed in libstdc++ soon
thereafter, but there are likely other standard libraries where this will fail.

By matching this function call with the other one, we fix this bug.

Differential Revision: https://reviews.llvm.org/D95769




More information about the All-commits mailing list